[PATCH] of_fix_tree: fo not fail when fixup fails
Marc Reilly
marc at cpdesign.com.au
Wed Sep 23 15:35:54 PDT 2015
Hi,
Should the subject be "do not fail .." (s/fo/do) ?
Cheers,
Marc
On Wednesday, September 23, 2015 05:23:56 PM Sascha Hauer wrote:
> When a device tree fixup fails it is worth printing a warning, but
> we should not fail booting.
>
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> ---
> common/oftree.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/common/oftree.c b/common/oftree.c
> index cafe46c..d408f14 100644
> --- a/common/oftree.c
> +++ b/common/oftree.c
> @@ -189,11 +189,9 @@ int of_fix_tree(struct device_node *node)
>
> list_for_each_entry(of_fixup, &of_fixup_list, list) {
> ret = of_fixup->fixup(node, of_fixup->context);
> - if (ret) {
> - pr_err("Failed to fixup node in %pS: %s\n",
> + if (ret)
> + pr_warn("Failed to fixup node in %pS: %s\n",
> of_fixup->fixup, strerror(-ret));
> - return ret;
> - }
> }
>
> return 0;
More information about the barebox
mailing list