[PATCH] MIPS: start.S depends on banner

[Antony Pavlov]

On Wed, 16 Sep 2015 10:35:23 +0200
Sascha Hauer <s.hauer at pengutronix.de> wrote:

> On Wed, Sep 16, 2015 at 10:50:33AM +0300, Antony Pavlov wrote:
> > On Wed, 16 Sep 2015 14:40:48 +0800
> > Kevin Du Huanpeng <u74147 at gmail.com> wrote:
> > 
> > > Signed-off-by: Kevin Du Huanpeng <u74147 at gmail.com>
> > > ---
> > >  arch/mips/Kconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > > index aeb5c04..fde4c2e 100644
> > > --- a/arch/mips/Kconfig
> > > +++ b/arch/mips/Kconfig
> > > @@ -6,6 +6,7 @@ config MIPS
> > >  	select HAS_KALLSYMS
> > >  	select HAVE_CONFIGURABLE_MEMORY_LAYOUT
> > >  	select HAVE_CONFIGURABLE_TEXT_BASE
> > > +	select BANNER
> > >  	default y
> > >  
> > >  config SYS_SUPPORTS_BIG_ENDIAN
> > > -- 
> > > 1.9.1
> > > 
> > 
> > IMHO we can make banner use in start.S optional. E.g.:
> > 
> > diff --git a/arch/mips/boot/start.S b/arch/mips/boot/start.S
> > index 7e2ae5e..f3a6a00 100644
> > --- a/arch/mips/boot/start.S
> > +++ b/arch/mips/boot/start.S
> > @@ -22,8 +22,10 @@
> >  #include <asm/mipsregs.h>
> >  #include <asm/asm.h>
> >  #include <asm-generic/memory_layout.h>
> > +#ifdef CONFIG_BANNER
> >  #include <generated/compile.h>
> >  #include <generated/utsrelease.h>
> > +#endif
> 
> CONFIG_BANNER and this compilation failure have nothing to do with each
> other.

Yes, but now I see that some parts of MIPS start.S and PBL need a code refactoring.
:)
 
-- 
Best regards,
  Antony Pavlov