[PATCH] login: make some locally used functions static

Antony Pavlov antonynpavlov at gmail.com
Sat Oct 31 23:12:58 PDT 2015


On Fri, 30 Oct 2015 15:55:00 +0300
Sergey Koshechkin <tritel59 at gmail.com> wrote:

> This patch continues cleanup password code from
> 
>   commit 40596b856f61c281fb34f804bf42550c099f26c3
>   Author: Sascha Hauer <s.hauer at pengutronix.de>
>   Date:   Thu Aug 27 15:58:50 2015 +0200
> 
>       login: cleanup password code


... and this patch fixes some 'no previous prototype' warnings:

common/password.c:114:5: warning: no previous prototype for ‘is_passwd_default_enable’ [-Wmissing-prototypes]
 int is_passwd_default_enable(void)
     ^
common/password.c:120:5: warning: no previous prototype for ‘is_passwd_env_enable’ [-Wmissing-prototypes]
 int is_passwd_env_enable(void)
     ^
common/password.c:230:5: warning: no previous prototype for ‘write_env_passwd’ [-Wmissing-prototypes]
 int write_env_passwd(unsigned char *sum, size_t length)
     ^

> 
> Signed-off-by: Sergey Koshechkin <tritel59 at gmail.com>
> ---
>  common/password.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/common/password.c b/common/password.c
> index b5b7655..5b754d9 100644
> --- a/common/password.c
> +++ b/common/password.c
> @@ -111,13 +111,12 @@ int password(unsigned char *passwd, size_t length, int flags, int timeout)
>  }
>  EXPORT_SYMBOL(password);
>  
> -int is_passwd_default_enable(void)
> +static int is_passwd_default_enable(void)
>  {
>  	return strlen(default_passwd) > 0;
>  }
> -EXPORT_SYMBOL(is_passwd_default_enable);
>  
> -int is_passwd_env_enable(void)
> +static int is_passwd_env_enable(void)
>  {
>  	int fd;
>  
> @@ -130,7 +129,6 @@ int is_passwd_env_enable(void)
>  
>  	return 1;
>  }
> -EXPORT_SYMBOL(is_passwd_env_enable);
>  
>  int passwd_env_disable(void)
>  {
> @@ -227,7 +225,7 @@ exit:
>  }
>  EXPORT_SYMBOL(read_env_passwd);
>  
> -int write_env_passwd(unsigned char *sum, size_t length)
> +static int write_env_passwd(unsigned char *sum, size_t length)
>  {
>  	int fd;
>  	unsigned char c;
> @@ -274,7 +272,6 @@ exit:
>  
>  	return ret;
>  }
> -EXPORT_SYMBOL(write_env_passwd);
>  
>  static int check_passwd(unsigned char *passwd, size_t length)
>  {
> -- 
> 2.6.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox


-- 
-- 
Best regards,
  Antony Pavlov



More information about the barebox mailing list