[RFC] common: filetype: is_fat_or_mbr() considered harmful

[Sascha Hauer]

Hi Peter,

On Wed, Oct 07, 2015 at 09:03:56PM +0300, Peter Mamonov wrote:
> Deleted pieces of code detect MBR-containig device as a FAT-type device,
> if it's first partition contains a FAT filesystem. So, one can mount the first
> partition of a hard drive containing FAT FS using the following command:
> 	barebox: mount /dev/ata0.0 /mnt/0
> as well as this one:
> 	barebox: mount /dev/ata0 /mnt/1
> Both commands mount the same FS.
> 
> This behaviour causes automount (mount -a) to mount FAT FS
> on a first partition twice:
> 	barebox: mount
> 	none on / type ramfs
> 	none on /dev type devfs
> 	/dev/ata0 on /mnt/ata0 type fat
> 	/dev/ata0.0 on /mnt/ata0.0 type fat
> 	/dev/ata0.1 on /mnt/ata0.1 type ext4

This is_fat_or_mbr mechanism never worked very well and had funny side
effects. Would be nice to get rid of it.
Simply removing this option is not a solution though, we have to find a
proper way to keep the current feature and make it more sane.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |