[PATCH] at91sam9x5: for ROM base address (bugfix for nand ECC)

[Sascha Hauer]

On Thu, Oct 01, 2015 at 11:59:36PM +0200, Alessandro Rubini wrote:
> > Subject: [PATCH] at91sam9x5: for ROM base address (bugfix for nand ECC)
> 
> Argh! After a lot of editing, the subject line is wrong.
> 
>    fix ROM base address (bugfix for nand ECC)

I applied the patch with this spelling fix and your name written
correctly.

> 
> Anyways, let me add this detail.  The current code considers the
> case where dev_request_mem_region() fails.
> 
>         host->pmecc_rom_base = dev_request_mem_region(dev, 3);
>         if (!host->pmecc_rom_base) {
>                    [...]
> 
> What it does in "[...]" is creating the tables with proper math..  I
> tried to skip the request_mem_region() above and ECC works perfectly,
> with the software-generated table.
> 
> So I wonder whether it makes sense to just remove the declaration of
> the ROM are memory-region-3 for NAND, and just use the software-built
> tables.

Are the software defined tables on all SoCs identical to the ROM tables?
If not that may be a reason to use the software tables only as a
fallback.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |