[PATCH] devinfo: fix return value

Sascha Hauer s.hauer at pengutronix.de
Mon Jun 22 23:40:29 PDT 2015


devinfo on a non existing device prints:

no such device: blah
devinfo: Operation not permitted

The second message comes because devinfo returns -1 which is -EPERM.

Just return -ENODEV which will print:

devinfo: No such device

Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
---
 commands/devinfo.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/commands/devinfo.c b/commands/devinfo.c
index e61aaa2..3c9d6a6 100644
--- a/commands/devinfo.c
+++ b/commands/devinfo.c
@@ -68,11 +68,8 @@ static int do_devinfo(int argc, char *argv[])
 		}
 	} else {
 		dev = get_device_by_name(argv[1]);
-
-		if (!dev) {
-			printf("no such device: %s\n",argv[1]);
-			return -1;
-		}
+		if (!dev)
+			return -ENODEV;
 
 		if (dev->num_resources)
 			printf("Resources:\n");
-- 
2.1.4




More information about the barebox mailing list