Clocks on Barebox

[andreas.willig at rafi.de]

Hi Sascha,

you make my day :) this is it, everything is fine, i removed my Workaround with hardinit osc to tree, and everything works smooth and beautiful :)

Problem solved, looking Forward, seeing this patch on branch next :)

Mit freundlichen Grüßen aus Berg/ With kind regards

i.A. Andreas Willig
Dipl.-Ing. (FH)
Entwicklung Elektronik

RAFI GmbH & Co. KG
Postfach 2060
88276 Ravensburg
Tel.: +49 (0) 751 89-6142

mailto:andreas.willig at rafi.de, http://www.rafi.de

Kommanditgesellschaft: Sitz Berg, Amtsgericht Ulm, HRA 550059
Komplementär: RAFI Beteiligungs-GmbH, Sitz Berg, Amtsgericht Ulm HRB 550074
Geschäftsführer: Albert Wasmeier, Dipl.-Kfm. Gerhard Schenk
USt-Ident.-Nr.: DE 146 392 319, Steuer-Nr.: 77079/00291


-----Sascha Hauer <s.hauer at pengutronix.de> schrieb: ----- 
An: andreas.willig at rafi.de
Von: Sascha Hauer <s.hauer at pengutronix.de>
Datum: 10.06.2015 06:59
Kopie: barebox at lists.infradead.org
Betreff: Re: Clocks on Barebox


On Tue, Jun 09, 2015 at 01:28:17PM +0200, andreas.willig at rafi.de wrote:
> Hi Sascha,
> 
> here my oftables section from barebox.map:
> 
> .oftables       0x278f7bc0       0x18
>                 0x278f7bc0                . = ALIGN (0x8)
>                 0x278f7bc0                __clk_of_table_start = .
>  *(.__clk_of_table_*)
>  .__clk_of_table_end
>                 0x278f7bc0        0x8 drivers/built-in.o
>                 0x278f7bc0                __clk_of_table_sentinel
>  .__clk_of_table_fixed_clk
>                 0x278f7bc8        0x8 drivers/built-in.o
>                 0x278f7bc8                __clk_of_table_fixed_clk
>  .__clk_of_table_fixed_factor_clk
>                 0x278f7bd0        0x8 drivers/built-in.o
>                 0x278f7bd0                __clk_of_table_fixed_factor_clk
>                 0x278f7bd8                __clk_of_table_end = .

And here's the problem. The sentinel entry containing only NULL marks
the end of the array. It should be the last entry, but here it's the
first entry which effectively makes the table empty. It turned out it
was pure luck that the sentinel entry ended up as last entry normally.

I've just sent out a patch fixing this, please test.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |