[PATCH] mfd: da9053: add basic da9053 driver

[Sascha Hauer]

On Thu, Jan 29, 2015 at 04:43:17PM +0100, Michael Grzeschik wrote:
> From: Jan Luebbe <jlu at pengutronix.de>
> 
> Signed-off-by: Jan Luebbe <jlu at pengutronix.de>
> ---
>  drivers/mfd/Kconfig  |   4 +
>  drivers/mfd/Makefile |   1 +
>  drivers/mfd/da9053.c | 360 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 365 insertions(+)
>  create mode 100644 drivers/mfd/da9053.c
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 3af904d..3d230f1 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -4,6 +4,10 @@ config MFD_ACT8846
>  	depends on I2C
>  	bool "ACT8846 driver"
>  
> +config MFD_DA9053
> +	depends on I2C
> +	bool "DA9053 PMIC driver"

You either need a "depends on WATCHDOG" or a if
(IS_ENABLED(CONFIG_WATCHDOG) in your code.

What do the "shutdown" and "faultlog" parameters do? At least a comment
in the code, better in the documentation would be good.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |