[PATCH] commands/splash: fix '-y' option handling

Sascha Hauer s.hauer at pengutronix.de
Mon Jan 26 00:16:45 PST 2015


On Sun, Jan 25, 2015 at 04:22:13PM +0300, Antony Pavlov wrote:
> The '-y' and '-o' options are independent,
> so just add missing 'break'.
> 
> Signed-off-by: Antony Pavlov <antonynpavlov at gmail.com>

Applied, thanks.

> ---
>  commands/splash.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/commands/splash.c b/commands/splash.c
> index 9bd84fb..077c0e4 100644
> --- a/commands/splash.c
> +++ b/commands/splash.c
> @@ -41,6 +41,7 @@ static int do_splash(int argc, char *argv[])
>  			break;
>  		case 'y':
>  			s.y = simple_strtoul(optarg, NULL, 0);
> +			break;
>  		case 'o':
>  			offscreen = 1;

It is missing here aswell. It's the last case, so this is not currently
a bug, but it could easily turn into a bug once the next option is
added.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list