[RFC, PATCH] i.MX6: phytec: Do not hardcode default environment

Andrey Smirnov andrew.smirnov at gmail.com
Tue Jan 6 12:15:05 PST 2015


> Looking at it you should rather replace the compatible checks in
> phytec_pfla02_init with their baseboards, so instead of:
>
>         if (!of_machine_is_compatible("phytec,imx6q-pfla02") &&
>                         !of_machine_is_compatible("phytec,imx6dl-pfla02") &&
>                         !of_machine_is_compatible("phytec,imx6s-pfla02"))
>                 return 0;
>
> do a:
>
>         if (!of_machine_is_compatible("phytec,imx6x-pbab01") &&
>                         !of_machine_is_compatible("phytec,imx6dl-pbab05") &&
>                         !of_machine_is_compatible("phytec,imx6q-pbab02"))
>                 return 0;
>
> Then the phytec default env will only be added for the phytec baseboards
> and not for your custom one. Note phyflex_err006282_workaround() won't
> be called either then, you may need your own version of this then.
>

Good point. I'll look into it.

Thanks,
Andrey



More information about the barebox mailing list