[PATCH 04/16] of: make first argument of several of_property_*_string functions const

Sascha Hauer s.hauer at pengutronix.de
Sat Feb 28 23:27:17 PST 2015


On Sat, Feb 28, 2015 at 10:40:09PM +0100, Marc Kleine-Budde wrote:
> Signed-off-by: Marc Kleine-Budde <mkl at pengutronix.de>
> ---
>  drivers/of/base.c |  8 ++++----
>  include/of.h      | 16 ++++++++--------
>  2 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index af10fd1da32c..4b5d4d75f19c 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -799,7 +799,7 @@ EXPORT_SYMBOL_GPL(of_property_read_u64);
>   *
>   * The out_string pointer is modified only if a valid string can be decoded.
>   */
> -int of_property_read_string(struct device_node *np, const char *propname,
> +int of_property_read_string(const struct device_node *np, const char *propname,
>  				const char **out_string)

Is this necessary for something or just a nice to have? The functions
are takes from the kernel and the device_node arguments cannot be const
there because the functions take a reference on the node.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list