saveenv & erase with bad blocks present

[Sascha Hauer]

Hi Marc-Andre,

I just sent an updated series for the nand issues. With this I tested
bootstrapping the board completly from SD card using the nand_bootstrap
script. I also tested 'saveenv' successfully.

On Mon, Feb 09, 2015 at 01:37:26PM +0000, Boulais, Marc-Andre wrote:
> Hi Sascha,
> I start the patched/fixed version in second stage. My PCM049 board is
> programmed with Phytec's BSP Barebox 2013.06.0. Upon entering its
> prompt, I start v 15.02.0 with your patches using tftp and bootm
> commands.
> 
> The "wrong crc on env superblock" message appears after I execute
> v15.02.0 with the bootm comand. It does not appear in the resident
> Barebox startup.
> 
> Note: The first time I tried your patches, I had this error message:
> nand_erase_nand: attempt to erase a bad block at page [...]
> 
> Since we were considering potential problems in the nand driver to
> cause a "false" bad block, I commented out the bad block check in
> function nand_erase_nand() (nand/nand_base.c):

>  	instr->state = MTD_ERASING;
> 
> 	while (len) {
> #if 0
> 		/* Check if we have a bad block, we do not erase bad blocks! */
> 		if (!mtd->allow_erasebad &&
> 				nand_block_checkbad(mtd, ((loff_t) page) <<
> 					chip->page_shift, 0, allowbbt)) {
> 			pr_warn("%s: attempt to erase a bad block at page 0x%08x\n",
> 				    __func__, page);
> 			instr->state = MTD_ERASE_FAILED;
> 			goto erase_exit;
> 		}
> #endif

The way to do this without sourcecode changes is to enable
CONFIG_NAND_ALLOW_ERASE_BAD and do a 'nand0.erasebad=1'

You should make sure to use a consistent barebox version state for both
the MLO and the full barebox later. Unfortunately the ECC layout
information and partition information of the NAND is stored in the
bootloader binaries and not on the device. This makes for a good source
of unpredictable errors.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |