[PATCH] ARM: Remove kernel booting call for thumb2 mode

Trent Piepho tpiepho at kymetacorp.com
Fri Dec 4 11:19:41 PST 2015


On Fri, 2015-12-04 at 08:30 +0100, Sascha Hauer wrote:
> On Fri, Dec 04, 2015 at 02:28:40AM +0000, Trent Piepho wrote:
> > 
> > This doesn't seem necessary for the same reason as the code in
> > start_linux.  THUMB2 selects AEABI, which in turn turns on the aapcs
> > abi, which requires interworking safe indirect calls.  And again, the
> > bootstrap code doesn't use a special call sequence so if it didn't work
> > that would be broken too.
> > 

> 
> This is a bug. We want to shift argv[] by one, not by two. I must
> accidently have done this twice.
> As you note the thumb2 execution code is unnecessary anyway, we can
> remove the bug by removing the code.

Ok, I'll send a patch for it.  I thought maybe there was some sort of
gcc bug or deficiency back in 2011 that made this necessary.  Though I
did search for bug with thumb interworking or "mov pc, reg" and didn't
find any that looked like they would be relevant.


More information about the barebox mailing list