[PATCH 1/3] commands: Add MMC ext. CSD register tool

Jan Lübbe jlu at pengutronix.de
Tue Aug 25 06:16:19 PDT 2015


On Di, 2015-08-25 at 09:06 +0200, Sascha Hauer wrote:
> Your printfs are very inefficient. You should use something like:
> 
>         if (val)
>                 str = "en";
>         else
>                 str = "dis";
>         printf("Command queuing is %sabled\n", str);
> 
> Same goes for many other printfs. This will result in much less
> similar strings in the binary.

or like this:
printf("Command queuing is %sabled\n", val ? "en" : "dis");

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |




More information about the barebox mailing list