[PATCH] RFC: include/usb/ch9.h: pad usb_endpoint_descriptor with 1 byte

Antony Pavlov antonynpavlov at gmail.com
Fri Aug 21 02:04:48 PDT 2015


On Thu, 20 Aug 2015 18:22:18 +0300
Peter Mamonov <pmamonov at gmail.com> wrote:

> This patch fixes "Ooops, address error on load or ifetch!",
> caused by "usb" command on MIPS architecture.
> 
> To reproduce the problem follow the following steps:
> 
> 1. Build barebox for MIPS target with -O0 optimization flag:
> 
> diff --git a/Makefile b/Makefile
> index 5a7fd5f..da9a8be 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -301,7 +301,7 @@ CPPFLAGS        := -D__KERNEL__ -D__BAREBOX__ $(LINUXINCLUDE) -fno-builtin -ffre
> 
>  CFLAGS          := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
>                     -Werror-implicit-function-declaration \
> -                   -fno-strict-aliasing -fno-common -Os -pipe
> +                   -fno-strict-aliasing -fno-common -O0 -pipe
>  AFLAGS          := -D__ASSEMBLY__
> 
>  LDFLAGS_barebox        := -Map barebox.map

It's better to add some indentation here because the patches with patches in commit message make problem for 'git am'.

Also it's better to change the subject of the message. Use "[RFC]" instead of "[PATCH] RFC:".
Please see --subject-prefix git-format-patch option.

-- 
Best regards,
  Antony Pavlov



More information about the barebox mailing list