[PATCH v2] i2c-imx: Add missing preporcessor directives

Sam Ravnborg sam at ravnborg.org
Sat Aug 15 13:53:49 PDT 2015

Hi Andrey.

On Sat, Aug 15, 2015 at 09:44:31AM -0700, Andrey Smirnov wrote:
> On non-PowerPC platforms call to i2c_fsl_set_clk() will try to obtain
> I2C clock freqency from i2c_fsl->clk, however that field would not be
> initialized if CONFIG_COMMON_CLK is not set. This patch makes sure
> that i2c_fls_set_clk() is a no-op on non-PPC targets when
> CONFIG_COMMON_CLK is not set

Per the other mail we will never hit this case.
So you add an ifdef that never will be used,
because this driver is either for IMX (which uses COMMON_CLK) or PowerPC.

There is this snip from the driver:

        i2c_fsl->clk = clk_get(pdev, NULL);
        if (IS_ERR(i2c_fsl->clk))
                return PTR_ERR(i2c_fsl->clk);

You may have been inspired by that.
To the best of my understanding the ifdef can be dropped,
because clk_dev() is always defined, but retinr NULL if
HAVE_CLK is not defined.
I assume thsi is the case for PowerPC.

So the better fix would be to get rid of this ifdet,
rather than introducing a new one.


More information about the barebox mailing list