[PATCH 1/2] net: smc1111: fix platform data initializations

Robert Jarzmik robert.jarzmik at free.fr
Mon Apr 13 10:53:21 PDT 2015


Sascha Hauer <s.hauer at pengutronix.de> writes:

> On Sat, Apr 11, 2015 at 11:42:41PM +0200, Robert Jarzmik wrote:
>>  		pdata->config_setup = pdata->config_setup;
>>  		pdata->control_setup = pdata->control_setup;
>> +		priv->config_setup = pdata->config_setup;
>> +		priv->control_setup = pdata->control_setup;
>
> This should be:
>
>  		if (pdata->bus_width == 16)
>  			priv->a = access_via_16bit;
> -		pdata->config_setup = pdata->config_setup;
> -		pdata->control_setup = pdata->control_setup;
> +		priv->config_setup = pdata->config_setup;
> +		priv->control_setup = pdata->control_setup;
>  	}
>
> Fixed this while applying because this is master material and I want to
> make a release today.

Silly me, you're very right, thanks for the "on the fly" repatching.

Cheers.

-- 
Robert



More information about the barebox mailing list