[PATCH 5/9] net: macb: using default value for FBLDO

Bo Shen voice.shen at atmel.com
Sun Sep 21 22:08:49 PDT 2014


Hi Sascha,

On 09/22/2014 12:59 PM, Sascha Hauer wrote:
> On Wed, Sep 17, 2014 at 06:21:31PM +0800, Bo Shen wrote:
>> Signed-off-by: Bo Shen <voice.shen at atmel.com>
>> ---
>>
>>   drivers/net/macb.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
>> index 12a2a3c..ef49f74 100644
>> --- a/drivers/net/macb.c
>> +++ b/drivers/net/macb.c
>> @@ -304,7 +304,6 @@ static void macb_configure_dma(struct macb_device *bp)
>>   	if (macb_is_gem(bp)) {
>>   		dmacfg = gem_readl(bp, DMACFG) & ~GEM_BF(RXBS, -1L);
>>   		dmacfg |= GEM_BF(RXBS, bp->rx_buffer_size / RX_BUFFER_MULTIPLE);
>> -		dmacfg |= GEM_BF(FBLDO, 16);
>
> Why is this done? Does this still work on other SoCs?

Yes, as this hard code which cause the sama5d4 Ethernet won't work. So, 
I remove this hard code and use the register default value.

> Sascha
>

Best Regards,
Bo Shen




More information about the barebox mailing list