[PATCH v3] commands: of_dump switch to get fixed devictree

Sascha Hauer s.hauer at pengutronix.de
Mon Sep 1 03:34:27 PDT 2014


On Thu, Aug 21, 2014 at 04:15:07PM +0400, Antony Pavlov wrote:
> On Thu, 21 Aug 2014 13:26:19 +0200
> Jan Weitzel <j.weitzel at phytec.de> wrote:
> 
> > Add a switch to get the devicetree processed by the registered fixups.
> > This is also whats the kernel gets.
> > 
> >  BAREBOX_CMD_START(of_dump)
> >  	.cmd		= do_of_dump,
> >  	BAREBOX_CMD_DESC("dump devicetree nodes")
> > -	BAREBOX_CMD_OPTS("[-f] [NODE]")
> > +	BAREBOX_CMD_OPTS("[-fF] [NODE]")
> 
> This is a bit confusing. The '-f' option has one argument,
> but '-F' option has noone.
> 
> IMHO this solution is more accurate:
> 
> +	BAREBOX_CMD_OPTS("[-F] [-f NODE]")

Indeed it's more accurate, but the way Jan did it is in line with the
other commands.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list