[PATCH 1/5] mtd: nand: remove NAND_ATMEL_PMECC
Sascha Hauer
s.hauer at pengutronix.de
Mon Sep 1 02:49:28 PDT 2014
On Wed, Aug 06, 2014 at 09:21:52AM +0200, Raphaël Poggi wrote:
> Ok, I did it because we need a structure member to retrieve
> "atmel,has-pmecc" from device tree.
>
> Is this ok if I add the has_pmecc member (feed by atmel_nand_of_init),
> let the NAND_ATMEL_PMECC, and the if will be like :
>
> if (IS_ENABLED(CONFIG_NAND_ATMEL_PMECC) || pdata->has_pmecc)
Shouldn't this be && instead of ||?
Otherwise this approach should be fine.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the barebox
mailing list