[PATCH 2/3] mxs: iomux-imx23/imx28: unify mode definition

Juergen Borleis jbe at pengutronix.de
Fri Oct 24 00:50:21 PDT 2014


Hi Uwe,

On Friday 24 October 2014 00:46:00 Uwe Kleine-König wrote:
> [...]
>  #if defined CONFIG_ARCH_IMX23
> +/*
> + * The pin definition of i.MX23 are strange. Bank 0's pins 0 .. 15 are defined
> + * using PORTF(0, 0) .. PORTF(0, 15). Its pins 16 .. 31 however use PORTF(1, 0)
> + * .. PORTF(1, 15). So the PORTF macro is more ugly than necessary.
> + */ 
> +# define PORTF(bank,bit)	(BANK((bank) / 2) | BANKPIN((((bank) & 1) << 4) | (bit)) | ERROR((bit) & ~15) | ERROR((bank) & ~7)
> +# define VE_2_5V		VOLTAGE(1)
>  # include <mach/iomux-imx23.h>
>  #endif
> +

Looks more like a strange implementation by myself. Did not remember why I have
done it in this way...

jbe

-- 
Pengutronix e.K.                              | Juergen Borleis             |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |



More information about the barebox mailing list