[PATCH] Clean up Kconfig and source for a couple device tree commands.

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Sun Jul 6 23:39:32 PDT 2014


On Jul 5, 2014, at 12:18 AM, Robert P. J. Day <rpjday at crashcourse.ca> wrote:

> 
> 
> Correct options listings for a couple device tree-related commands.
> 
> Signed-off-by: Robert P. J. Day <rpjday at crashcourse.ca>
> 
> ---
> 
>  i *think* the following is valid.
> 
> diff --git a/commands/Kconfig b/commands/Kconfig
> index eed6fbd..3248de9 100644
> --- a/commands/Kconfig
> +++ b/commands/Kconfig
> @@ -1950,10 +1950,11 @@ config CMD_OFTREE
> 	help
> 	  oftree - handle device trees
> 
> -	  Usage: oftree [-lpfdn] [DTB]
> +	  Usage: oftree [-lspf] [DTB]
> 
> 	  Options:
> 		  -l		Load DTB to internal device tree
> +		  -s		save internal device tree to DTB
> 		  -p		probe devices from stored device tree
> 		  -f		free stored device tree
> 

do we really need the help here

it’s a pain in the ass to keep it sync


> diff --git a/commands/of_dump.c b/commands/of_dump.c
> index e341942..cafde07 100644
> --- a/commands/of_dump.c
> +++ b/commands/of_dump.c
> @@ -101,7 +101,7 @@ BAREBOX_CMD_HELP_END
> BAREBOX_CMD_START(of_dump)
> 	.cmd		= do_of_dump,
> 	BAREBOX_CMD_DESC("dump devicetree nodes")
> -	BAREBOX_CMD_OPTS("[-f]")
> +	BAREBOX_CMD_OPTS("[-f] [NODE]")
> 	BAREBOX_CMD_GROUP(CMD_GRP_MISC)
> 	BAREBOX_CMD_COMPLETE(devicetree_file_complete)
> 	BAREBOX_CMD_HELP(cmd_of_dump_help)
> diff --git a/commands/oftree.c b/commands/oftree.c
> index a3b0e04..983a0a5 100644
> --- a/commands/oftree.c
> +++ b/commands/oftree.c
> @@ -145,7 +145,7 @@ BAREBOX_CMD_HELP_END
> BAREBOX_CMD_START(oftree)
> 	.cmd		= do_oftree,
> 	BAREBOX_CMD_DESC("handle device trees")
> -	BAREBOX_CMD_OPTS("[-lpfs]")
> +	BAREBOX_CMD_OPTS("[-lspf]")
> 	BAREBOX_CMD_GROUP(CMD_GRP_MISC)
> 	BAREBOX_CMD_HELP(cmd_oftree_help)
> BAREBOX_CMD_END
> 
> -- 
> 
> ========================================================================
> Robert P. J. Day                                 Ottawa, Ontario, CANADA
>                        http://crashcourse.ca
> 
> Twitter:                                       http://twitter.com/rpjday
> LinkedIn:                               http://ca.linkedin.com/in/rpjday
> ========================================================================
> 
> _______________________________________________
> barebox mailing list
> barebox at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox




More information about the barebox mailing list