[RFC 3/3] libbb: read_full: use read return instead size
Alexander Aring
alex.aring at gmail.com
Fri Feb 28 03:03:34 EST 2014
On Fri, Feb 28, 2014 at 08:44:28AM +0100, Alexander Aring wrote:
> Signed-off-by: Alexander Aring <alex.aring at gmail.com>
> ---
> lib/libbb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/libbb.c b/lib/libbb.c
> index 189a170..c8d0835 100644
> --- a/lib/libbb.c
> +++ b/lib/libbb.c
> @@ -162,7 +162,7 @@ int read_full(int fd, void *buf, size_t size)
> int now;
> int total = 0;
>
> - while (size) {
> + while (now) {
> now = read(fd, buf, size);
> if (now == 0)
> return total;
and this should be a:
do {
...
} while (now);
sry, it's only to demonstrate the issue.
- Alex
More information about the barebox
mailing list