Re: [PATCH] Adding minimal support for the UDOO board.

[Alexander Shiyan]

Понедельник, 17 февраля 2014, 8:48 +01:00 от Sascha Hauer <s.hauer at pengutronix.de>:
> Hi Raphaël,
> 
> On Sun, Feb 16, 2014 at 02:20:08PM -0800, Raphaël POGGI wrote:
> > From: Raphael Poggi <poggi.raph at gmail.com>
> > 
> > For more information about the board: http://www.udoo.org/
> > 
> > Signed-off-by: Raphael Poggi <poggi.raph at gmail.com>
> 
> Your patch contains several coding style issues, most significantly:
> Please use tabs for indendation, not spaces. You should run
> scripts/checkpatch.pl over your patch next time, it catches most of
> the issues.
> Otherwise your patch looks fine and I applied it after fixing the coding
> style.
...
> > +++ b/arch/arm/dts/imx6q-udoo.dts
> > @@ -0,0 +1,23 @@
> > +/*
> > + * Copyright 2014 Raphaël Poggi
> > + * Copyright 2012 Freescale Semiconductor, Inc.
> > + * Copyright 2011 Linaro Ltd.
> > + *
> > + * The code contained herein is licensed under the GNU General Public
> > + * License. You may obtain a copy of the GNU General Public License
> > + * Version 2 or later at the following locations:
> > + *
> > + * http://www.opensource.org/licenses/gpl-license.html
> > + * http://www.gnu.org/copyleft/gpl.html
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "imx6q.dtsi"

Most likely you not need to include "imx6q.dtsi".

> > +#include "imx6qdl-udoo.dtsi"
> > +
> > +/ {
> > +       model = "Freescale i.MX6 Quad UDOO Board";
> > +       compatible = "fsl,imx6q-udoo", "fsl,imx6q";
> > +};
> > +
> > diff --git a/arch/arm/dts/imx6qdl-udoo.dtsi b/arch/arm/dts/imx6qdl-udoo.dtsi
> > new file mode 100644
> > index 0000000..c705684
> > --- /dev/null
> > +++ b/arch/arm/dts/imx6qdl-udoo.dtsi
> > @@ -0,0 +1,108 @@
> > +/*
> > + * Copyright 2014 Raphaël Poggi
> > + * Copyright 2011 Freescale Semiconductor, Inc.
> > + * Copyright 2011 Linaro Ltd.
> > + *
> > + * The code contained herein is licensed under the GNU General Public
> > + * License. You may obtain a copy of the GNU General Public License
> > + * Version 2 or later at the following locations:
> > + *
> > + * http://www.opensource.org/licenses/gpl-license.html
> > + * http://www.gnu.org/copyleft/gpl.html
> > + */
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/input/input.h>
> > +
> > +/ {

compatible ?

> > +       chosen {
> > +               linux,stdout-path = &uart2;
> > +
> > +       };
> > +
> > +       memory {
> > +               reg = <0x10000000 0x40000000>;
> > +       };
> > +
> > +       regulators {
> > +               compatible = "simple-bus";
> > +               #address-cells = <1>;
> > +               #size-cells = <0>;
> > +
> > +               reg_2p5v: regulator at 0 {
> > +                       compatible = "regulator-fixed";
> > +                       reg = <0>;
> > +                       regulator-name = "2P5V";
> > +                       regulator-min-microvolt = <2500000>;
> > +                       regulator-max-microvolt = <2500000>;
> > +                       regulator-always-on;
> > +               };
> > +
> > +               reg_3p3v: regulator at 1 {
> > +                       compatible = "regulator-fixed";
> > +                       reg = <1>;
> > +                       regulator-name = "3P3V";
> > +                       regulator-min-microvolt = <3300000>;
> > +                       regulator-max-microvolt = <3300000>;
> > +                       regulator-always-on;
> > +               };
> > +
> > +               reg_usb_otg_vbus: regulator at 2 {
> > +                       compatible = "regulator-fixed";
> > +                       reg = <2>;
> > +                       regulator-name = "usb_otg_vbus";
> > +                       regulator-min-microvolt = <5000000>;
> > +                       regulator-max-microvolt = <5000000>;
> > +                       gpio = <&gpio3 22 0>;
> > +                       enable-active-high;

gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;

...

---