[PATCH 1/2] kbuild: add ./Kbuild file to fix "make clean"

Masahiro Yamada yamada.m at jp.panasonic.com
Tue Dec 23 20:23:26 PST 2014


"make clean/mrproper/distclean" has not been working correctly.

When "make clean" is run, Kbuild descends into the directories
that are listed in "clean-dirs" variable, which includes $(srctree).

It intends descending into "./Kbuild", not "./Makefile".
(Note "Kbuild" takes precedence over "Makefile" in each directory.)

If Kbuild descends into "./Makefile", Kconfig is invoked via
"make silentoldconfig", which is not our intention.

Let's add "Kbuild" file at the top directory like Linux.

Update TODO list too.

Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
---

 Kbuild | 2 ++
 TODO   | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
 create mode 100644 Kbuild

diff --git a/Kbuild b/Kbuild
new file mode 100644
index 0000000..0c3f408
--- /dev/null
+++ b/Kbuild
@@ -0,0 +1,2 @@
+# This does nothing, but some (dummy) comments here.
+# If this file gets empty, it is removed by "make distclean".
diff --git a/TODO b/TODO
index 6350799..8527e57 100644
--- a/TODO
+++ b/TODO
@@ -4,7 +4,6 @@ TODO
 [ ] ask jbe about:
     ./commands/Makefile:40:obj-$(CONFIG_SIMPLE_PARSER)      += setenv.o
 [ ] bark on partition not ending on flash sector boundaries
-[ ] distclean doesn't work without a config
 [ ] Every driver should have a remove function.
     (It must have. Currently there is no provision to given to remove my
     interrupt handlers and to reset all hardware in use, before the target
@@ -108,3 +107,4 @@ DONE
     countdown -m msg -t timeout -x [ctrl-c|anykey|string]
     If done, remove the corresponding stuff from common/main.c
 [X] Board support should go to arch/*/boards/*
+[X] distclean doesn't work without a config
-- 
1.9.1




More information about the barebox mailing list