[PATCH 1/5] usb: gadget: fastboot: allow to build without BOOTM

[Sascha Hauer]

On Mon, Dec 15, 2014 at 12:35:16PM +0100, Lucas Stach wrote:
> > Instead of the #ifdef can we do a:
> > 
> > 	if (!IS_ENABLED(CONFIG_BOOTM)) {
> > 		fastboot_tx_print(f_fb, "FAILCommand not supported");
> > 		return;
> > 	}
> > 
> > in cb_boot?
> > 
> Actually I like they way I did it in this patch better, as it is
> explicit about why something is not available. Chasing through the code
> just to find out why cb_boot returned early with an error seems like
> obfuscation to me. Also it spreads the same error path through 2
> functions which isn't nice if we ever have to change something there.

I still like the green better, but applied.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |