[PATCH 06/10] net: orion-gbe: use transparent-to-driver of mdio functions

Ezequiel Garcia ezequiel.garcia at free-electrons.com
Sat Aug 2 10:44:15 PDT 2014


Hello Sascha,

On 21 May 02:18 PM, Sascha Hauer wrote:
[..]
>  
> +	sprintf(dev->name, "orion-gbe-port");
> +	dev->id = port->portno;
> +	dev->parent = parent;
> +	dev->device_node = port->np;
> +	ret = register_device(dev);
> +	if (ret)
> +		return ret;
> +

Can you clarify why you added this device register? I didn't find the need
to do so in the mvneta driver, but maybe I overlooked something.

Thanks!
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com



More information about the barebox mailing list