[PATCH 1/2] Add initial regulator support

Sascha Hauer s.hauer at pengutronix.de
Mon Apr 28 13:00:30 PDT 2014


On Mon, Apr 28, 2014 at 08:51:21PM +0200, Alexander Aring wrote:
> Hi,
> 
> On Mon, Apr 28, 2014 at 08:47:02PM +0200, Sascha Hauer wrote:
> > 
> > I think both functions should return 0 without a valid gpio instead.
> > Anyway, there's something wrong here.
> > 
> 
> maybe checking on this at probe time, at the beginning or can this gpio
> changed at runtime?
> 
> Maybe you don't need this here because probe will already failed with a
> invalid gpio.

No, the gpio is optional. Getting a fixed regulator without software
control is one usecase of the driver, just like in the kernel.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list