[PATCH 4/4] imx6: Add support for phyCARD-i.MX6

[Lucas Stach]

Am Freitag, den 25.04.2014, 15:10 +0200 schrieb Alexander Aring:
> Hi,
> 
> On Fri, Apr 25, 2014 at 01:54:28PM +0200, Christian Hemp wrote:
> > Add support for Phytec phyCARD-i.MX6.
> > 	- 1GB RAM on two banks
> > 	- 1GB RAM on one bank
> > 	- 2GB RAM on two banks
> ...
> > +
> > +extern char __dtb_imx6q_phytec_pbaa03_start[];
> > +
> > +ENTRY_FUNCTION(start_phytec_pbaa03_1gib, r0, r1, r2)
> > +{
> > +	uint32_t fdt;
> > +
> > +	arm_cpu_lowlevel_init();
> > +
> > +	arm_setup_stack(0x00920000 - 8);
> > +
> > +	if (IS_ENABLED(CONFIG_DEBUG_LL))
> > +		setup_uart();
> > +
> > +	fdt = (uint32_t)__dtb_imx6q_phytec_pbaa03_start - get_runtime_offset();
> > +
> > +	barebox_arm_entry(0x10000000, SZ_1G, fdt);
> > +}
> > +
> > +ENTRY_FUNCTION(start_phytec_pbaa03_1gib_1bank, r0, r1, r2)
> > +{
> > +	uint32_t fdt;
> > +
> > +	arm_cpu_lowlevel_init();
> > +
> > +	arm_setup_stack(0x00920000 - 8);
> > +
> > +	if (IS_ENABLED(CONFIG_DEBUG_LL))
> > +		setup_uart();
> > +
> > +	fdt = (uint32_t)__dtb_imx6q_phytec_pbaa03_start - get_runtime_offset();
> > +
> > +	barebox_arm_entry(0x10000000, SZ_1G, fdt);
> > +}
> > +
> 
> Don't see a difference between start_phytec_pbaa03_1gib_1bank and
> start_phytec_pbaa03_1gib. Maybe you can write a new function and these
> two functions can call this function...
> 
> It's a design question...
> 
If those two are really meant to be the same, you don't even need two
entry functions. Just build a single PBL and add different DCDs through
the image mechanism.

Regards,
Lucas
-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |