[PATCH 1/3] net/ifup.c: don't fail silently

[Juergen Borleis]

Since commit a162dfe50345d3461010759f8a0e79f7e388c140 the ifup command is
implemented in C and runs up to two external scripts.
If one of these scripts return with an error code, the command terminates
silently. This can confuse a user because there is no hint about the reason
why it fails. Add error messages to avoid this case.
    
Signed-off-by: Juergen Borleis <jbe at pengutronix.de>

diff --git a/net/ifup.c b/net/ifup.c
index 7b6313629666..b259a975dc0b 100644
--- a/net/ifup.c
+++ b/net/ifup.c
@@ -70,14 +70,18 @@ int ifup(const char *name, unsigned flags)
 	cmd_discover = asprintf("/env/network/%s-discover", name);
 
 	ret = run_command(cmd);
-	if (ret)
+	if (ret) {
+		pr_err("Running '%s' failed with %d\n", cmd, ret);
 		goto out;
+	}
 
 	ret = stat(cmd_discover, &s);
 	if (!ret) {
 		ret = run_command(cmd_discover);
-		if (ret)
+		if (ret) {
+			pr_err("Running '%s' failed with %d\n", cmd, ret);
 			goto out;
+		}
 	}
 
 	dev = get_device_by_name(name);

-- 
Pengutronix e.K.                              | Juergen Borleis             |
Linux Solutions for Science and Industry      | Phone: +49-5121-206917-5128 |
Peiner Str. 6-8, 31137 Hildesheim, Germany    | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686              | http://www.pengutronix.de/  |