[PATCH v2 2/2] commands: uimage: remove redundant error message

Lucas Stach dev at lynxeye.de
Mon Apr 21 06:50:35 PDT 2014


uimage_verify already prints an error message if the CRC
is wrong. Romove the never reached redundant message in
the caller.

Signed-off-by: Lucas Stach <dev at lynxeye.de>
---
 commands/uimage.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/commands/uimage.c b/commands/uimage.c
index 345e49600c81..bdc74448d9e5 100644
--- a/commands/uimage.c
+++ b/commands/uimage.c
@@ -62,12 +62,9 @@ static int do_uimage(int argc, char *argv[])
 	if (verify) {
 		printf("verifying data crc... ");
 		ret = uimage_verify(handle);
-		if (ret) {
+		if (ret)
 			goto err;
-			printf("Bad Data CRC\n");
-		} else {
-			printf("ok\n");
-		}
+		printf("ok\n");
 	}
 
 	if (extract) {
-- 
1.9.0




More information about the barebox mailing list