[PATCH 08/11] ARM: socfpga: Add FPGA programming command

[Steffen Trumtrar]

On Mon, Sep 16, 2013 at 01:09:14PM +0200, Sascha Hauer wrote:
> Hi Steffen,
> 
> On Mon, Sep 16, 2013 at 12:40:41PM +0200, Steffen Trumtrar wrote:
> > Hi!
> > 
> > On Mon, Sep 16, 2013 at 10:48:17AM +0200, Sascha Hauer wrote:
> > > This adds a simple socfpga specific 'fpga' command to load a firmware
> > > to the FPGA. For the moment this is enough, but should we get more
> > > FPGA support it might be a good idea to introduce some generic framework
> > > and command.
> > > 
> > > Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> > > ---
> > >  arch/arm/mach-socfpga/Kconfig                     |   5 +
> > >  arch/arm/mach-socfpga/Makefile                    |   1 +
> > >  arch/arm/mach-socfpga/fpga.c                      | 422 ++++++++++++++++++++++
> > >  arch/arm/mach-socfpga/include/mach/socfpga-regs.h |   2 +
> > >  4 files changed, 430 insertions(+)
> > >  create mode 100644 arch/arm/mach-socfpga/fpga.c
> > > 
> > 
> > Why did you chose to have an extra command for fpga loading instead of having
> > just a (block)device? Do you see any future advantage in that or is it just
> > because of the port from u-boot? I know that they need an extra fpga command, but
> > they also have an extra mmcload command and stuff.
> 
> Main reason was that I was unsure how good a block device will be when
> we get a different firmware format to load (rbf vs. sof vs. something
> else)
> 

Aha, okay. If we want/need to support different formats, than a special
command might be necessary. At least when the format is not easy to
autodetect, I guess.

Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |