Re: [PATCH] console: Obey "linux, stdout-path" parameter regardless of CONSOLE_ACTIVATE_XX

Alexander Shiyan shc_work at mail.ru
Fri Oct 25 23:38:01 EDT 2013


> On Fri, Oct 25, 2013 at 07:23:48PM +0400, Alexander Shiyan wrote:
> > Signed-off-by: Alexander Shiyan <shc_work at mail.ru>
> > ---
> >  common/console.c  |  4 ++--
> >  drivers/of/base.c | 13 ++++---------
> >  include/of.h      |  2 +-
> >  3 files changed, 7 insertions(+), 12 deletions(-)
...
> Can you elaborate why you need this patch? Normally on devicetree based
> boards I set CONSOLE_ACTIVATE_NONE. In this case I think your patch
> changes nothing. If you set CONSOLE_ACTIVATE_ALL or
> CONSOLE_ACTIVATE_FIRST your patch seems to overwrite the Kconfig setting
> with the devicetree setting. Why don't you set CONSOLE_ACTIVATE_NONE in
> the first place?

You are right. Lets forget this patch.

---


More information about the barebox mailing list