[PATCH] fs: ignore O_TRUNC open flag for devices
Sascha Hauer
s.hauer at pengutronix.de
Wed Oct 16 05:04:17 EDT 2013
The O_TRUNC flag has to be ignored when opening devices. Otherwise
cp /somefile /dev/somedev fails. This is broken since:
| commit d4f5bb1e011ac653a167031554f0ac9e028e9e36
| Author: Sascha Hauer <s.hauer at pengutronix.de>
| Date: Sat Sep 28 13:12:50 2013 +0200
|
| copy_file: Add missing O_TRUNC
|
| Without it, when copying a smaller file over a larger file the
| resulting file still has the remaining space from the larger file.
|
| Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
---
Many usecases are broken on the latest release without this patch so
I'll make a stable release with it.
fs/fs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/fs.c b/fs/fs.c
index ce7b425..7d558e9 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -722,8 +722,7 @@ int open(const char *pathname, int flags, ...)
if (ret)
goto out;
-
- if (flags & O_TRUNC) {
+ if (!(s.st_mode & S_IFCHR) && (flags & O_TRUNC)) {
ret = fsdrv->truncate(&fsdev->dev, f, 0);
f->size = 0;
if (ret)
--
1.8.4.rc3
More information about the barebox
mailing list