[RFC PATCH 1/2] AM33XX: Move muxing defines to header file

Jan Lübbe jlu at pengutronix.de
Thu Mar 14 05:35:43 EDT 2013


On Thu, 2013-03-14 at 08:30 +0100, Sascha Hauer wrote:
> Hi Teresa,
> 
> On Tue, Mar 12, 2013 at 03:04:12PM +0100, Teresa Gámez wrote:
> > The muxing in the am33xx_mux.c file is not generic as the muxing
> > setup does not fit for every board. Move the structs and functions
> > to the mach/am33xx-mux.h so board dependend mux setups can be
> > created.
> > 
> > Signed-off-by: Teresa Gámez <t.gamez at phytec.de>
> 
> Looks good to me. Jan is more familiar with the am33xx. Jan,
> could you have a look on it?

I haven't tested it, but the approach seems good. When adding a new
board, I would probably have done the same.

The current PinMux is still a bit BeagleBone-specific, but that should
be fixed in a separate patch. (Or instead write a pinctrl-single driver
and configure PinMux via DT).

Regards,
Jan
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |




More information about the barebox mailing list