[PATCH 4/5] gadget: possible null pointer dereference fix

[Sascha Hauer]

On Wed, Mar 13, 2013 at 02:44:39PM +0100, Cerrato Renaud wrote:
> This patch fix a possible null pointer dereference exception because of a missing null check on cdev->config
> 
> Signed-off-by: Cerrato Renaud <r.cerrato at til-technologies.fr>
> ---
>  drivers/usb/gadget/composite.c |   23 +++++++++++++----------
>  1 files changed, 13 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> index 9af115e..1f6c5b2 100644
> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -777,18 +777,21 @@ unknown:
>           * recipients (endpoint, other, WUSB, ...) to the current
>           * configuration code.
>           */
> -        f = cdev->config->interface[intf];
> -        if (f && f->setup)
> -            value = f->setup(f, ctrl);
> -        else
> -            f = NULL;
> +        if(cdev->config) {

please do a:

	if (!cdev->config)
		goto out;

instead.

Your patch is whitespace damaged, I won't be able to apply it.
As Jean-Christophe mentioned, you should use git-send-mail for sending
your patches. It does things just right.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |