Re[2]: [PATCH 04/13] ARM: clps711x: Add clocksource driver

[Alexander Shiyan]

> On Mon, Mar 11, 2013 at 12:01:58PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > +static int clps711x_cs_probe(struct device_d *dev)
> > > +{
> > > +	u32 rate;
> > > +	struct clk *timer_clk;
> > > +
> > > +	timer_clk = clk_get(dev, NULL);
> > > +	if (IS_ERR(timer_clk))
> > > +		return PTR_ERR(timer_clk);
> > > +
> > > +	rate = clk_get_rate(timer_clk);
> > > +	clps711x_timer_base = dev_request_mem_region(dev, 0);
> > > +	if (!clps711x_timer_base) {
> > > +		clk_put(timer_clk);
> > > +		return -ENOENT;
> > > +	}
> > this deserve a nice crash
> 
> No, it doesn't. First of all we are very early here, so we might not even
> see the crash. Then, with devicetree probing we may often end up with
> the same devices registered from the devicetree and from the
> platform/soc. While this should find a way to avoid duplicate device
> registration, it is not nice having barebox crash in this case.

So what is the solution you propose in this case?

---