Re: [RFC] Makefile: Create empty <config.h> if this header file is not needed by board

Alexander Shiyan shc_work at mail.ru
Sun Mar 10 07:08:00 EDT 2013


> Patch creates empty <config.h> if this header is not needed by board.
> This will allow to remove many empty config.h files from boards.
> 
> Signed-off-by: Alexander Shiyan <shc_work at mail.ru>
> ---
>  Makefile | 17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index b5819fc..e8d9984 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -898,13 +898,18 @@ include/asm:
>  	$(Q)$(check-symlink)
>  	$(Q)$(create-symlink)
>  
> +define symlink-config-h
> +	if [ -f $(srctree)/$(BOARD)/config.h ]; then		\
> +		$(kecho) '  SYMLINK $@ -> $(BOARD)/config.h';	\
> +		ln -fsn $(srctree)/$(BOARD)/config.h $@;	\
> +	else							\
> +		$(kecho) '  CREATE  $@';			\
> +		echo -n > $@;					\
> +	fi
> +endef
> +
>  include/config.h: include/config/auto.conf
> -	$(Q)$(kecho) '  SYMLINK $@ -> $(BOARD)/config.h'
> -ifneq ($(KBUILD_SRC),)
> -	$(Q)ln -fsn $(srctree)/$(BOARD)/config.h $@
> -else
> -	$(Q)ln -fsn ../$(BOARD)/config.h $@
> -endif
> +	$(Q)$(symlink-config-h)
>  
>  # Generate some files
>  # ---------------------------------------------------------------------------
> -- 
> 1.7.12.4

Can anyone comment this patch?
I can resend it with cleanup part. (-50 files).

---


More information about the barebox mailing list