[PATCH] Extend device_platform_driver macro
Sascha Hauer
s.hauer at pengutronix.de
Sat Mar 9 10:12:30 EST 2013
Hi Alexander,
On Fri, Mar 08, 2013 at 01:05:14PM +0400, Alexander Shiyan wrote:
> This patch extends device_platform_driver macro, so now we allow
> use it with various init levels and subsystems.
>
> Signed-off-by: Alexander Shiyan <shc_work at mail.ru>
> ---
> include/driver.h | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/include/driver.h b/include/driver.h
> index 46c56c0..b891f80 100644
> --- a/include/driver.h
> +++ b/include/driver.h
> @@ -395,16 +395,19 @@ extern struct bus_type platform_bus;
>
> int platform_driver_register(struct driver_d *drv);
>
> -/* device_platform_driver() - Helper macro for drivers that don't do
> +/* register_driver_macro() - Helper macro for drivers that don't do
> * anything special in module registration. This eliminates a lot of
> * boilerplate. Each module may only use this macro once.
> */
> -#define device_platform_driver(drv) \
> - static int __init drv ## _register(void) \
> - { \
> - return platform_driver_register(&drv); \
> - } \
> - device_initcall(drv ## _register)
> +#define register_driver_macro(level,subsystem,drv) \
> + static int __init drv##_register(void) \
> + { \
> + return subsystem##_driver_register(&drv); \
> + } \
> + level##_initcall(drv##_register)
So the usage would look like:
register_driver_macro(device, i2c, &mc_driver)
?
I'm not sure if I like this. I'm a bit concerned about being able
to grep for for example i2c_register_driver. This would become
wcgrep register_driver_macro | grep i2c
or similar.
What do others think about it?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the barebox
mailing list