[PATCH] usb: ehci: initialize ehci_data
Sascha Hauer
s.hauer at pengutronix.de
Fri Mar 8 02:24:53 EST 2013
Hi Antony,
On Fri, Mar 08, 2013 at 09:57:10AM +0400, Antony Pavlov wrote:
> On 4 March 2013 20:00, Sascha Hauer <s.hauer at pengutronix.de> wrote:
> > Without it fields of ehci_data may be unitialized and the driver
> > crashes.
>
> Sascha!
>
> Please apply a patch like this! Without it the 'usb' command on my
> Tegra board hangs.
Just did that.
Sascha
>
>
> > Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> > ---
> > drivers/usb/host/ehci-hcd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> > index 0c789e4..7c389aa 100644
> > --- a/drivers/usb/host/ehci-hcd.c
> > +++ b/drivers/usb/host/ehci-hcd.c
> > @@ -892,7 +892,7 @@ int ehci_register(struct device_d *dev, struct ehci_data *data)
> >
> > static int ehci_probe(struct device_d *dev)
> > {
> > - struct ehci_data data;
> > + struct ehci_data data = {};
> > struct ehci_platform_data *pdata = dev->platform_data;
> >
> > /* default to EHCI_HAS_TT to not change behaviour of boards
> > --
> > 1.7.10.4
> >
> >
> > _______________________________________________
> > barebox mailing list
> > barebox at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox
>
>
>
> --
> Best regards,
> Antony Pavlov
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the barebox
mailing list