[PATCH] usb: ehci: initialize ehci_data

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Mon Mar 4 14:05:29 EST 2013


On 17:00 Mon 04 Mar     , Sascha Hauer wrote:
> Without it fields of ehci_data may be unitialized and the driver
> crashes.
> 
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> ---
>  drivers/usb/host/ehci-hcd.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 0c789e4..7c389aa 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -892,7 +892,7 @@ int ehci_register(struct device_d *dev, struct ehci_data *data)
>  
>  static int ehci_probe(struct device_d *dev)
>  {
> -	struct ehci_data data;
> +	struct ehci_data data = {};

I'll prefer a memset
>  	struct ehci_platform_data *pdata = dev->platform_data;
>  
>  	/* default to EHCI_HAS_TT to not change behaviour of boards
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox



More information about the barebox mailing list