[PATCH 29/37] of_* commands: print usage when insufficient arguments are given

Sascha Hauer s.hauer at pengutronix.de
Mon Mar 4 04:53:32 EST 2013


Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
---
 commands/of_node.c     |    3 +++
 commands/of_property.c |    3 +++
 2 files changed, 6 insertions(+)

diff --git a/commands/of_node.c b/commands/of_node.c
index 2f6ecae..171ea2c 100644
--- a/commands/of_node.c
+++ b/commands/of_node.c
@@ -54,6 +54,9 @@ static int do_of_node(int argc, char *argv[])
 		}
 	}
 
+	if (optind == argc)
+		return COMMAND_ERROR_USAGE;
+
 	if (optind < argc) {
 		path = argv[optind];
 	}
diff --git a/commands/of_property.c b/commands/of_property.c
index 585522c..bd9ff72 100644
--- a/commands/of_property.c
+++ b/commands/of_property.c
@@ -192,6 +192,9 @@ static int do_of_property(int argc, char *argv[])
 		}
 	}
 
+	if (optind == argc)
+		return COMMAND_ERROR_USAGE;
+
 	root = of_get_root_node();
 	if (!root) {
 		printf("root node not set\n");
-- 
1.7.10.4




More information about the barebox mailing list