[PATCH 08/12] PCM051: Add first stage support

Jan Lübbe jlu at pengutronix.de
Mon Jul 8 10:39:54 EDT 2013


On Mon, 2013-07-08 at 15:17 +0200, Teresa Gámez wrote:
> @@ -153,13 +154,20 @@
>  #define AM33XX_DATA0_RD_DQS_SLAVE_RATIO_1      (AM33XX_DDR_PHY_BASE_ADDR + 0x0CC)
>  #define        AM33XX_DATA0_WR_DQS_SLAVE_RATIO_0       (AM33XX_DDR_PHY_BASE_ADDR + 0x0DC)
>  
> +#define        AM33XX_DATA1_RD_DQS_SLAVE_RATIO_0 (AM33XX_DDR_PHY_BASE_ADDR + 0x16C)
> +#define        AM33XX_DATA1_WR_DQS_SLAVE_RATIO_0 (AM33XX_DDR_PHY_BASE_ADDR + 0x180)
> +#define        AM33XX_DATA1_FIFO_WE_SLAVE_RATIO_0 (AM33XX_DDR_PHY_BASE_ADDR + 0x1AC)
> +#define        AM33XX_DATA1_WR_DATA_SLAVE_RATIO_0 (AM33XX_DDR_PHY_BASE_ADDR + 0x1C4)
> +
>  #define        AM33XX_DATA0_WR_DQS_SLAVE_RATIO_1       (AM33XX_DDR_PHY_BASE_ADDR + 0x0E0)
>  #define        AM33XX_DATA0_WRLVL_INIT_RATIO_0         (AM33XX_DDR_PHY_BASE_ADDR + 0x0F0)

Could we keep the defines ordered by address?
Also, it seems that the alignment is inconsistent.

Regards,
Jan
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |




More information about the barebox mailing list