[PATCH v2 00/10] ARM: mvebu: DT support, SPI, GPIO driver, and Dove DT

Sebastian Hesselbarth sebastian.hesselbarth at gmail.com
Fri Jul 5 05:40:58 EDT 2013


On 07/05/13 08:57, Sascha Hauer wrote:
> On Thu, Jul 04, 2013 at 01:40:24PM +0200, Sebastian Hesselbarth wrote:
>> currently mvebu on next is broken because of missing
>> "OF: address and device related sync and cleanup" patch set.
>>
>> I should have stated clearly that this patch set depends on
>> the former set.
>>
>> Can you re-test the OF address/device patches and check if
>> they still break SPI chip select gpio on efikasb?
>
> I applied the series and based the Marvell patches ontop of it. I
> haven't tested on EfiksSB but on another board with a SPI controller, so
> I assume this issue is fixed now.

Ok, I explicitly tested of_get_named_gpio with lcd-gpio driver on Dove.
If there are more issues on the now applied set, please do not hesitate
to mention it and request fixes.

> Please note that your of address cleanup series adds about 1.8k to the
> binary size. This doesn't sound too much, but such stuff really sums up
> over time. I agree that we can't do without proper address translation
> in the future, so I applied it. Just be aware in the future that we
> still need a good compromise between binary size and sophisticated code.

True. Now that I can start improving DT only mach-mvebu, I will have an
extra eye on what of the existing and imported functions can be
converted or simplified. If it leads to a significant binary size
reduction, I will send patches.

I will also prepare the last remaining node looping fix for
of_find_node_with_property later.

Thanks for the reviews!

Sebastian




More information about the barebox mailing list