[PATCH 00/12] add bus device

Sascha Hauer s.hauer at pengutronix.de
Mon Oct 29 06:41:37 EDT 2012


On Mon, Oct 15, 2012 at 04:49:35PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 15:21 Mon 15 Oct     , Sascha Hauer wrote:
> > On Mon, Oct 15, 2012 at 12:23:07PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > On 09:10 Mon 15 Oct     , Sascha Hauer wrote:
> > > > +	ret = register_device(&bus->bus_dev);
> > > > +	if (ret)
> > > > +		return ret;
> > > > +
> > > >  	list_add_tail(&bus->list, &bus_list);
> > > >  
> > > >  	return 0;
> > > > diff --git a/drivers/base/driver.c b/drivers/base/driver.c
> > > > index 5b7286a..395546b 100644
> > > > --- a/drivers/base/driver.c
> > > > +++ b/drivers/base/driver.c
> > > > @@ -127,6 +127,11 @@ int register_device(struct device_d *new_device)
> > > >  
> > > >  	list_add_tail(&new_device->bus_list, &new_device->bus->device_list);
> > > >  
> > > > +	if (!new_device->parent) {
> > > > +		new_device->parent = &new_device->bus->dev;
> > > > +		dev_add_child(new_device->parent, new_device);
> > > and I was wanting to add global name "barebox" and add everyone under to it
> > > 
> > > I choose to do let the bus manage the child
> > > and to create a device or not
> > 
> > Any idea why we would need this?
> mdio bus as example I was thinking to drop the device as they are always
> attached to a ethernet device

They are not. drivers/net/ksz8864rmn.c for example is a switch driver
for which no ethernet device exists.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list