[PATCH] common: Makefile: 'cd' command could lead to broken default_env.h

Wolfram Sang w.sang at pengutronix.de
Mon Oct 22 13:14:08 EDT 2012


Depending on the user's settings (CDPATH), 'cd' may print out the
directory which was changed to. This causes broken barebox_default_env.h
to be generated. Ignore the cd printout.

Signed-off-by: Wolfram Sang <w.sang at pengutronix.de>
---
 common/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/Makefile b/common/Makefile
index 132bd06..f2c8a2e 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -99,7 +99,7 @@ $(obj)/barebox_default_env.lzo: $(obj)/barebox_default_env FORCE
 	$(call if_changed,lzo)
 
 quiet_cmd_env_h = ENVH    $@
-cmd_env_h = cat $< | (cd $(obj) && $(objtree)/scripts/bin2c default_environment) > $@; \
+cmd_env_h = cat $< | (cd $(obj) > /dev/null && $(objtree)/scripts/bin2c default_environment) > $@; \
 	echo "const int default_environment_uncompress_size=`stat -c%s $(obj)/barebox_default_env`;" >> $@
 
 $(obj)/barebox_default_env.h: $(obj)/barebox_default_env$(barebox_default_env_comp) FORCE
-- 
1.7.10.4




More information about the barebox mailing list