[PATCH 5/5] omap4_usbboot_fs: add benchmarking capabilities

Sascha Hauer s.hauer at pengutronix.de
Sat Oct 13 14:27:46 EDT 2012


On Sat, Oct 13, 2012 at 04:03:27PM +0200, Vicente wrote:
> @@ -166,6 +168,10 @@ int read_asic_id(struct usb_handle *usb)
>  struct file_data {
>  	size_t size;
>  	void *data;
> +#ifdef BENCHMARK
> +	size_t readden;
> +	struct timespec opened;
> +#endif

I don't think it's a good idea to add such debug stuff to the
repository. In the end the code gets harder to maintain with
such ifdeffery and there's not much gain in it.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list