[PATCH 1/1] designware: add clock support

Johannes Stezenbach js at sig21.net
Mon Oct 8 05:03:13 EDT 2012


On Sun, Oct 07, 2012 at 03:03:03PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> allow the driver to request it's clock and enable it
...
> +	clk = clk_get(dev, NULL);
> +	if (IS_ERR(clk)) {
> +		ret = PTR_ERR(clk);
> +		dev_err(dev, "no clk ret = %d\n", ret);
> +		return ret;
> +	}

Just a minor nit: s/allow/require/.  Users of the driver may
now have to define a dummy clock.  Since the actual clock freqeuency
is not used by the driver you could also make it optional?

And while at it, it's "its", not "it's". :-)

Johannes



More information about the barebox mailing list