[PATCH 3/3] ARM: Add CLPS711X architecture

[Sascha Hauer]

On Sun, Oct 07, 2012 at 02:57:01PM +0400, Alexander Shiyan wrote:
> On Sun, 7 Oct 2012 12:45:50 +0200
> Sascha Hauer <s.hauer at pengutronix.de> wrote:
> 
> ...
> > And in the driver:
> > 
> > #define SYSCON		0x100
> > 
> > 	...
> > 	writel(0xdeadbeef, base + SYSCON);
> > 	...
> You a right, but SYSCON is used not only for UARTs. This register also
> used for setup timers, keypad, lcd, spi etc... Just look on bit definitions.
> Same I can say about other resisters.

Oh my gosh, that indeed looks strange... Normally register regions are
reserved for separate units, on this SoC it seems more that bit
positions inside registers are reserved for separate units ;)

> In this case we have some redundancy definitions. I will think about other way.

Try and have a look if you could clean this up a bit, but it might be
that you already found the best solution.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |