[PATCH 2/4] gpio: provide generic gpio header

[Sascha Hauer]

On Fri, Oct 05, 2012 at 01:18:41PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> ---
>  include/asm-generic/gpio.h |   10 ++++++++++
>  1 file changed, 10 insertions(+)
>  create mode 100644 include/asm-generic/gpio.h
> 
> diff --git a/include/asm-generic/gpio.h b/include/asm-generic/gpio.h
> new file mode 100644
> index 0000000..1997888
> --- /dev/null
> +++ b/include/asm-generic/gpio.h
> @@ -0,0 +1,10 @@
> +#ifndef __ASM_GENERIC_GPIO_H
> +#define __ASM_GENERIC_GPIO_H
> +
> +void gpio_set_value(unsigned gpio, int value);
> +int gpio_get_value(unsigned gpio);
> +int gpio_direction_output(unsigned gpio, int value);
> +int gpio_direction_input(unsigned gpio);
> +
> +#endif /* __ASM_GENERIC_GPIO_H */
> +

No newline at end of file please.

Since you are adding a generic file, which is good, could you also
cleanup the potential users?

./arch/arm/mach-at91/include/mach/gpio.h
./arch/arm/mach-mxs/include/mach/gpio.h
./arch/arm/mach-imx/include/mach/gpio.h
./arch/arm/mach-pxa/include/plat/gpio.h
./arch/arm/mach-pxa/include/mach/gpio.h
./arch/arm/mach-samsung/include/mach/gpio.h
./arch/arm/mach-ep93xx/include/mach/gpio.h
./arch/arm/mach-omap/include/mach/gpio.h

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |